Link Mapbox iOS SDK as a CocoaPods dependency, rather than using a script to download it.#6
Open
terryttsai wants to merge 1 commit intoscoot/6.1.2-pre-releasefrom
Open
Conversation
…igation, we update the podspec to use the same Mapbox iOS dependency as MapboxNavigation v0.16.2 and remove the vendored_framework file and the preinstall script that downloads it. We use MapboxNavigation v0.16.2 because that's the latest version of MapboxNavigation that is still compatible with Mapbox iOS SDK v3.7.3, same as RNMGL.
terryttsai
requested review from
cpetzel,
javashaman,
jluxenberg-scoot and
willmortonscoot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to resolve conflicting Mapbox.framework files with MapboxNavigation, we update the podspec to use the same Mapbox iOS dependency as MapboxNavigation v0.16.2 and remove the vendored_framework file and the preinstall script that downloads it. We use MapboxNavigation v0.16.2 because that's the latest version of MapboxNavigation that is still compatible with Mapbox iOS SDK v3.7.3, same as RNMGL.